tests_exist.c 4.3 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137
  1. #include <tools/ccanlint/ccanlint.h>
  2. #include <ccan/tal/str/str.h>
  3. #include <ccan/tal/path/path.h>
  4. #include <sys/types.h>
  5. #include <sys/stat.h>
  6. #include <fcntl.h>
  7. #include <unistd.h>
  8. #include <limits.h>
  9. #include <errno.h>
  10. #include <stdlib.h>
  11. #include <stdio.h>
  12. #include <err.h>
  13. static void check_tests_exist(struct manifest *m,
  14. unsigned int *timeleft, struct score *score);
  15. static struct ccanlint tests_exist = {
  16. .key = "tests_exist",
  17. .name = "Module has test directory with tests in it",
  18. .check = check_tests_exist,
  19. .needs = "info_exists"
  20. };
  21. REGISTER_TEST(tests_exist);
  22. static void handle_no_tests(struct manifest *m, struct score *score)
  23. {
  24. FILE *run;
  25. struct ccan_file *i;
  26. char *test_dir = tal_fmt(m, "%s/test", m->dir), *run_file;
  27. printf(
  28. "CCAN modules have a directory called test/ which contains tests.\n"
  29. "There are four kinds of tests: api, run, compile_ok and compile_fail:\n"
  30. "you can tell which type of test a C file is by its name, eg 'run.c'\n"
  31. "and 'run-simple.c' are both run tests.\n\n"
  32. "The simplest kind of test is a run test, which must compile with no\n"
  33. "warnings, and then run: it is expected to use ccan/tap to report its\n"
  34. "results in a simple and portable format. It should #include the C\n"
  35. "files from the module directly (so it can probe the internals): the\n"
  36. "module will not be linked in. The test will be run in a temporary\n"
  37. "directory, with the test directory symlinked under test/.\n\n"
  38. "api tests are just like a run test, except it is a guarantee of API\n"
  39. "stability: this test should pass on all future versions of the\n"
  40. "module. They *are* linked to the module, since they should only\n"
  41. "test the API, not the internal state.\n\n"
  42. "compile_ok tests are a subset of run tests: they must compile and\n"
  43. "link, but aren't run.\n\n"
  44. "compile_fail tests are tests which should fail to compile (or emit\n"
  45. "warnings) or link when FAIL is defined, but should compile and link\n"
  46. "when it's not defined: this helps ensure unrelated errors don't make\n"
  47. "compilation fail.\n\n"
  48. "Note that only API tests are linked against the files in the module!\n"
  49. );
  50. if (!ask("Should I create a template test/run.c file for you?"))
  51. return;
  52. if (mkdir(test_dir, 0700) != 0) {
  53. if (errno != EEXIST)
  54. err(1, "Creating test/ directory");
  55. }
  56. run_file = tal_fmt(test_dir, "%s/run.c", test_dir);
  57. run = fopen(run_file, "w");
  58. if (!run)
  59. err(1, "Trying to create a test/run.c");
  60. fprintf(run, "#include <ccan/%s/%s.h>\n", m->modname, m->basename);
  61. if (!list_empty(&m->c_files)) {
  62. fputs("/* Include the C files directly. */\n", run);
  63. list_for_each(&m->c_files, i, list)
  64. fprintf(run, "#include <ccan/%s/%s>\n",
  65. m->modname, i->name);
  66. }
  67. fprintf(run, "%s",
  68. "#include <ccan/tap/tap.h>\n\n"
  69. "int main(void)\n"
  70. "{\n"
  71. " /* This is how many tests you plan to run */\n"
  72. " plan_tests(3);\n"
  73. "\n"
  74. " /* Simple thing we expect to succeed */\n"
  75. " ok1(some_test())\n"
  76. " /* Same, with an explicit description of the test. */\n"
  77. " ok(some_test(), \"%s with no args should return 1\", \"some_test\")\n"
  78. " /* How to print out messages for debugging. */\n"
  79. " diag(\"Address of some_test is %p\", &some_test)\n"
  80. " /* Conditional tests must be explicitly skipped. */\n"
  81. "#if HAVE_SOME_FEATURE\n"
  82. " ok1(test_some_feature())\n"
  83. "#else\n"
  84. " skip(1, \"Don\'t have SOME_FEATURE\")\n"
  85. "#endif\n"
  86. "\n"
  87. " /* This exits depending on whether all tests passed */\n"
  88. " return exit_status();\n"
  89. "}\n");
  90. fclose(run);
  91. }
  92. static void check_tests_exist(struct manifest *m,
  93. unsigned int *timeleft, struct score *score)
  94. {
  95. struct stat st;
  96. char *test_dir = path_join(m, m->dir, "test");
  97. if (lstat(test_dir, &st) != 0) {
  98. score->error = tal_strdup(score, "No test directory");
  99. if (errno != ENOENT)
  100. err(1, "statting %s", test_dir);
  101. tests_exist.handle = handle_no_tests;
  102. /* We "pass" this. */
  103. score->pass = true;
  104. return;
  105. }
  106. if (!S_ISDIR(st.st_mode)) {
  107. score->error = tal_strdup(score, "test is not a directory");
  108. return;
  109. }
  110. if (list_empty(&m->api_tests)
  111. && list_empty(&m->run_tests)
  112. && list_empty(&m->compile_ok_tests)
  113. && list_empty(&m->compile_fail_tests)) {
  114. score->error = tal_strdup(score, "No tests in test directory");
  115. tests_exist.handle = handle_no_tests;
  116. return;
  117. }
  118. score->pass = true;
  119. score->score = score->total;
  120. }