Browse Source

net: Add check for failure of setsockopt()

make_listen_fd() didn't check for failure of setsockopt().  There's no
real reason not to, since we have an obvious way to report an error to the
caller.

Found with Coverity Scan.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
David Gibson 8 years ago
parent
commit
5c1767485d
1 changed files with 3 additions and 1 deletions
  1. 3 1
      ccan/net/net.c

+ 3 - 1
ccan/net/net.c

@@ -238,7 +238,9 @@ static int make_listen_fd(const struct addrinfo *addrinfo)
 	if (fd < 0)
 	if (fd < 0)
 		return -1;
 		return -1;
 
 
-	setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on));
+	if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &on, sizeof(on)) != 0)
+		goto fail;
+
 	if (bind(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0)
 	if (bind(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0)
 		goto fail;
 		goto fail;