Browse Source

ccanlint: Report failures with --summary

When run in --summary mode ccanlint doesn't actually report whether it
passed or failed in the message .  In particular this means that when make
check is run with -j, it can be hard to tell which modules failed.

This adds a more obvious failure message.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
David Gibson 10 years ago
parent
commit
55e9c20591
1 changed files with 2 additions and 0 deletions
  1. 2 0
      tools/ccanlint/ccanlint.c

+ 2 - 0
tools/ccanlint/ccanlint.c

@@ -577,6 +577,8 @@ static bool run_tests(struct dgraph_node *all,
 	if (deps_fail_ignore && non_ccan_deps && build_failed) {
 	if (deps_fail_ignore && non_ccan_deps && build_failed) {
 		comment = " (missing non-ccan dependencies?)";
 		comment = " (missing non-ccan dependencies?)";
 		run.pass = true;
 		run.pass = true;
+	} else if (!run.pass) {
+		comment = " FAIL!";
 	}
 	}
 	printf("%sTotal score: %u/%u%s\n",
 	printf("%sTotal score: %u/%u%s\n",
 	       prefix, run.score, run.total, comment);
 	       prefix, run.score, run.total, comment);