Browse Source

tap: WANT_PTHREAD not HAVE_PTHREAD

I'm not sure that a "pthread-safe" tap library is very useful; how many
people have multiple threads calling ok()?

Kirill Shutemov noted that it gives a warning with -Wundef; indeed, we
should ask in this case whether they want pthread support, not whether the
system has pthread support to offer.
Rusty Russell 14 years ago
parent
commit
532feb88f5
1 changed files with 7 additions and 2 deletions
  1. 7 2
      ccan/tap/tap.c

+ 7 - 2
ccan/tap/tap.c

@@ -45,8 +45,13 @@ static int test_died = 0;
 static int test_pid;
 static int test_pid;
 
 
 /* Encapsulate the pthread code in a conditional.  In the absence of
 /* Encapsulate the pthread code in a conditional.  In the absence of
-   libpthread the code does nothing */
-#if HAVE_LIBPTHREAD
+   libpthread the code does nothing.
+
+   If you have multiple threads calling ok() etc. at the same time you would
+   need this, but in that case your test numbers will be random and I'm not
+   sure it makes sense. --RR
+*/
+#ifdef WANT_PTHREAD
 #include <pthread.h>
 #include <pthread.h>
 static pthread_mutex_t M = PTHREAD_MUTEX_INITIALIZER;
 static pthread_mutex_t M = PTHREAD_MUTEX_INITIALIZER;
 # define LOCK pthread_mutex_lock(&M)
 # define LOCK pthread_mutex_lock(&M)