Browse Source

ccanlint: fix scoring, add score details to --verbose.

Rusty Russell 16 years ago
parent
commit
39323f37b0
2 changed files with 14 additions and 5 deletions
  1. 11 2
      tools/ccanlint/ccanlint.c
  2. 3 3
      tools/ccanlint/tests/run_tests_valgrind.c

+ 11 - 2
tools/ccanlint/ccanlint.c

@@ -119,8 +119,13 @@ static bool run_test(struct ccanlint *i,
 
 
 	result = i->check(m);
 	result = i->check(m);
 	if (!result) {
 	if (!result) {
-		if (verbose)
-			printf("  %s: OK\n", i->name);
+		if (verbose) {
+			printf("  %s: OK", i->name);
+			if (i->total_score)
+				printf(" (+%u/%u)",
+				       i->total_score, i->total_score);
+			printf("\n");
+		}
 		if (i->total_score) {
 		if (i->total_score) {
 			*score += i->total_score;
 			*score += i->total_score;
 			*total_score += i->total_score;
 			*total_score += i->total_score;
@@ -141,6 +146,10 @@ static bool run_test(struct ccanlint *i,
 
 
 	*total_score += i->total_score;
 	*total_score += i->total_score;
 	*score += this_score;
 	*score += this_score;
+	if (verbose) {
+		printf("  %s: FAIL (+%u/%u)\n",
+		       i->name, this_score, i->total_score);
+	}
 	if (!quiet) {
 	if (!quiet) {
 		printf("%s\n", i->describe(m, result));
 		printf("%s\n", i->describe(m, result));
 
 

+ 3 - 3
tools/ccanlint/tests/run_tests_valgrind.c

@@ -49,7 +49,7 @@ static void *do_run_tests_vg(struct manifest *m)
 	list_head_init(list);
 	list_head_init(list);
 
 
 	list_for_each(&m->run_tests, i, list) {
 	list_for_each(&m->run_tests, i, list) {
-		run_tests.total_score++;
+		run_tests_vg.total_score++;
 		/* FIXME: timeout here */
 		/* FIXME: timeout here */
 		cmdout = run_command(m, "valgrind -q %s", i->compiled);
 		cmdout = run_command(m, "valgrind -q %s", i->compiled);
 		if (cmdout) {
 		if (cmdout) {
@@ -61,7 +61,7 @@ static void *do_run_tests_vg(struct manifest *m)
 	}
 	}
 
 
 	list_for_each(&m->api_tests, i, list) {
 	list_for_each(&m->api_tests, i, list) {
-		run_tests.total_score++;
+		run_tests_vg.total_score++;
 		/* FIXME: timeout here */
 		/* FIXME: timeout here */
 		cmdout = run_command(m, "valgrind -q %s", i->compiled);
 		cmdout = run_command(m, "valgrind -q %s", i->compiled);
 		if (cmdout) {
 		if (cmdout) {
@@ -87,7 +87,7 @@ static unsigned int score_run_tests_vg(struct manifest *m, void *check_result)
 {
 {
 	struct list_head *list = check_result;
 	struct list_head *list = check_result;
 	struct run_tests_result *i;
 	struct run_tests_result *i;
-	unsigned int score = run_tests.total_score;
+	unsigned int score = run_tests_vg.total_score;
 
 
 	list_for_each(list, i, list)
 	list_for_each(list, i, list)
 		score--;
 		score--;