Browse Source

Fix possible dereference on blank inputs during input_pool.

Con Kolivas 14 years ago
parent
commit
9a928e3407
1 changed files with 4 additions and 3 deletions
  1. 4 3
      main.c

+ 4 - 3
main.c

@@ -3126,8 +3126,8 @@ static char *curses_input(const char *query)
 
 
 static bool input_pool(bool live)
 static bool input_pool(bool live)
 {
 {
-	char *url, *user, *pass;
-	struct pool *pool;
+	char *url = NULL, *user = NULL, *pass = NULL;
+	struct pool *pool = NULL;
 	bool ret = false;
 	bool ret = false;
 
 
 	immedok(logwin, true);
 	immedok(logwin, true);
@@ -3179,13 +3179,14 @@ out:
 	immedok(logwin, false);
 	immedok(logwin, false);
 
 
 	if (!ret) {
 	if (!ret) {
-		free(pool);
 		if (url)
 		if (url)
 			free(url);
 			free(url);
 		if (user)
 		if (user)
 			free(user);
 			free(user);
 		if (pass)
 		if (pass)
 			free(pass);
 			free(pass);
+		if (pool)
+			free(pool);
 	}
 	}
 	return ret;
 	return ret;
 }
 }